dispatch: fix logging to a file on Windows #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Port the dispatch_debug test to Windows and fix a bug that it found related to logfile initialization. _dispatch_logv_init()'s Windows implementation uses _fdopen() and fprintf() to write the log header. However, this gives ownership of the file to stdio, so fclose() closes the descriptor and causes future writes to trigger CRT assertion failures. Avoid this by using snprintf() and _write() instead.
ktopley-apple
approved these changes
Feb 5, 2019
|
@swift-ci please test |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
dispatch: fix logging to a file on Windows Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the dispatch_debug test to Windows and fix a bug that it found related to
logfile initialization.
_dispatch_logv_init()'s Windows implementation uses _fdopen() and fprintf() to
write the log header. However, this gives ownership of the file to stdio, so
fclose() closes the descriptor and causes future writes to trigger CRT assertion
failures. Avoid this by using snprintf() and _write() instead.